[Doc] Note CI test allowlist and codegen-cache gotcha in CLAUDE.md#230
Merged
Conversation
The Running tests section now states that .github/workflows/pytorchsim_test.yml runs an explicit allowlist of tests/*.py (one Docker job per test, ~40 total), not a glob-discovered set, and calls out that test_gqa.py, test_gqa_decode.py, and test_eager.py exist in the repo but are not in CI. The Gotchas section adds a bullet explaining that codegen iteration requires wiping $TORCHSIM_DUMP_PATH between runs -- Inductor's compile cache and the per-source-hash MLIR/wrapper dirs both live under it and will silently replay the previous (possibly broken) compile otherwise. This prevents two common mistakes: assuming new tests/*.py files are automatically gated on PR, and assuming a fresh re-run will pick up a codegen fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
YWHyuk
force-pushed
the
docs/ci-test-allowlist
branch
from
8aa80a8 to
4ece129
Compare
YWHyuk
changed the title
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/pytorchsim_test.ymlis an explicit allowlist oftests/*.pyfiles (~40 jobs, one Docker container per test), not a glob-discovered set. Calls out thattests/test_gqa.py,tests/test_gqa_decode.py, andtests/test_eager.pyexist in the repo but are not in CI, so local validation is the only safety net for them.torch.compilewill replay the previously cached compile from$TORCHSIM_DUMP_PATH/<hash>/(and the Inductor compile cache at$TORCHSIM_DUMP_PATH/.torchinductor, pinned there byextension_config.py:139). Wipe$TORCHSIM_DUMP_PATHbetween iterations or the fix will silently not take.Motivation: both are gotchas that bit me during recent work; documenting once so the next contributor does not re-discover them.
🤖 Generated with Claude Code